Open
Conversation
|
My 2 cents on this: If NULL points on a specific platform to a valid address, then the defintion for NULL should be changed instead removing NULL pointer checks from code. |
Contributor
Author
|
Well it's not really a NULL pointer check in this case rather than the use of the NULL parameter for in-band signalling. It's just as valid to use the |
SPIFFS_write(&spi_fs, fd, buf, count) with buf = 0x0 can be valid when dumping the firmware of the microcontroller mapped to address 0x0. SPIFFS_write(&spi_fs, fd, 0x0, firmware_size) would previously omit the first page when dumping the firmware to flash (all 0xFF). Use len instead to signal where only page header is stored in spiffs_page_allocate_data
benpicco
force-pushed
the
null_write
branch
from
4a15f91 to
7a2abbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPIFFS_write(&spi_fs, fd, buf, count)withbuf = NULLcan be valid when dumping the firmware of a microcontroller with internal flash mapped to address0x0.SPIFFS_write(&spi_fs, fd, 0x0, firmware_size)would previously omit the first page when dumping the firmware to flash (all 0xFF).Visualization of the problem:
Use
leninstead to signal where only page header is stored inspiffs_page_allocate_data.